Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types.functionTo #3866

Merged
merged 2 commits into from
Sep 7, 2014
Merged

Remove types.functionTo #3866

merged 2 commits into from
Sep 7, 2014

Conversation

nbp
Copy link
Member

@nbp nbp commented Aug 29, 2014

A function is not a trivial concept, and the default value cannot be properly documented. As such, we should avoid using them as value of options.

The option environment.profileRelativeEnvVars represents the most common use case of environment.profileVariables, without using types.functionTo.

@nbp nbp force-pushed the remove-functionTo-type branch from 3c181a9 to 74babc8 Compare August 29, 2014 20:54
@bjornfor
Copy link
Contributor

bjornfor commented Sep 7, 2014

+1.

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Sep 7, 2014

Personally I disagree that functions are not trivial or hard to document but I do agree that in this particular scenario your solution works better and if it's the only scenario that uses functionTo then it should be fine to remove.

It does make me think whether there are no places where a function makes more sense than whatever it is currently using.

Just my 2 cents of course.

@nbp nbp force-pushed the remove-functionTo-type branch from 74babc8 to c6627f1 Compare September 7, 2014 17:14
@nbp
Copy link
Member Author

nbp commented Sep 7, 2014

The problem of functions, is that the default value and the definition cannot be automatically serialized, and thus tools such as the documentation / nixos-option / nixos-option-search have to deal with it.

Also, as strange as it might seems from a developer perspective, "function" is a term that a lot of persons forgot after college. So suggesting to a user to write a function is bad.

It does make me think whether there are no places where a function makes more sense than whatever it is currently using.

In general a user does not need to make a function, the only instance of a function which remains is not represented as a type in the module system. This is for nixpkgs.config.packageOverrides (see http://nixos.org/nixos/manual/#sec-customising-packages ).

@nbp nbp force-pushed the remove-functionTo-type branch from c6627f1 to 4ff1ab5 Compare September 7, 2014 17:41
nbp added a commit that referenced this pull request Sep 7, 2014
@nbp
Merge pull request #3866 from nbp/remove-functionTo-type
568f7d7 
Remove types.functionTo
@nbp nbp merged commit 568f7d7 into NixOS:master Sep 7, 2014
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Mar 8, 2020
@mweinelt
borgbackup: 1.1.10 → 1.1.11
dbff9b5 
Version 1.1.11 (2020-03-08)

Compatibility notes:

    When upgrading from borg 1.0.x to 1.1.x, please note:
        read all the compatibility notes for 1.1.0*, starting from 1.1.0b1.
        borg upgrade: you do not need to and you also should not run it.
        borg might ask some security-related questions once after upgrading. You can answer them either manually or via environment variable. One known case is if you use unencrypted repositories, then it will ask about a unknown unencrypted repository one time.
        your first backup with 1.1.x might be significantly slower (it might completely read, chunk, hash a lot files) - this is due to the --files-cache mode change (and happens every time you change mode). You can avoid the one-time slowdown by using the pre-1.1.0rc4-compatible mode (but that is less safe for detecting changed files than the default). See the --files-cache docs for details.
    1.1.11 removes WSL autodetection (Windows 10 Subsystem for Linux). If WSL still has a problem with sync_file_range, you need to set BORG_WORKAROUNDS=basesyncfile in the borg process environment to work around the WSL issue.

Fixes:

    fixed potential index corruption / data loss issue due to bug in hashindex_set, NixOS#4829 Please read and follow the more detailled notes close to the top of this document.
    upgrade bundled xxhash to 0.7.3, NixOS#4891 0.7.2 is the minimum requirement for correct operations on ARMv6 in non-fixup mode, where unaligned memory accesses cause bus errors. 0.7.3 adds some speedups and libxxhash 0.7.3 even has a pkg-config file now.
    upgrade bundled lz4 to 1.9.2
    upgrade bundled zstd to 1.4.4
    fix crash when upgrading erroneous hints file, NixOS#4922
    extract:
        fix KeyError for "partial" extraction, NixOS#4607
        fix "partial" extract for hardlinked contentless file types, NixOS#4725
        fix preloading for old (0.xx) remote servers, NixOS#4652
        fix confusing output of borg extract --list --strip-components, NixOS#4934
    delete: after double-force delete, warn about necessary repair, NixOS#4704
    create: give invalid repo error msg if repo config not found, NixOS#4411
    mount: fix FUSE mount missing st_birthtime, NixOS#4763 NixOS#4767
    check: do not stumble over invalid item key, NixOS#4845
    info: if the archive doesn't exist, print a pretty message, NixOS#4793
    SecurityManager.known(): check all files, NixOS#4614
    Repository.open: use stat() to check for repo dir, NixOS#4695
    Repository.check_can_create_repository: use stat() to check, NixOS#4695
    fix invalid archive error message
    fix optional/non-optional location arg, NixOS#4541
    commit-time free space calc: ignore bad compact map entries, NixOS#4796
    ignore EACCES (errno 13) when hardlinking the old config, NixOS#4730
    --prefix / -P: fix processing, avoid argparse issue, NixOS#4769

New features:

    enable placeholder usage in all extra archive arguments
    new BORG_WORKAROUNDS mechanism, basesyncfile, NixOS#4710
    recreate: support --timestamp option, NixOS#4745
    support platforms without os.link (e.g. Android with Termux), NixOS#4901 if we don't have os.link, we just extract another copy instead of making a hardlink.
    support linux platforms without sync_file_range (e.g. Android 7 with Termux), NixOS#4905

Other:

    ignore --stats when given with --dry-run, but continue, NixOS#4373
    add some ProgressIndicator msgids to code / fix docs, NixOS#4935
    elaborate on "Calculating size" message
    argparser: always use REPOSITORY in metavar, also use more consistent help phrasing.
    check: improve error output for matching index size, see NixOS#4829
    docs:
        changelog: add advisory about hashindex_set bug NixOS#4829
        better describe BORG_SECURITY_DIR, BORG_CACHE_DIR, NixOS#4919
        infos about cache security assumptions, NixOS#4900
        add FAQ describing difference between a local repo vs. repo on a server.
        document how to test exclusion patterns without performing an actual backup
        timestamps in the files cache are now usually ctime, NixOS#4583
        fix bad reference to borg compact (does not exist in 1.1), NixOS#4660
        create: borg 1.1 is not future any more
        extract: document limitation "needs empty destination", NixOS#4598
        how to supply a passphrase, use crypto devices, NixOS#4549
        fix osxfuse github link in installation docs
        add example of exclude-norecurse rule in help patterns
        update macOS Brew link
        add note about software for automating backups, NixOS#4581
        AUTHORS: mention copyright+license for bundled msgpack
        fix various code blocks in the docs, NixOS#4708
        updated docs to cover use of temp directory on remote, NixOS#4545
        add restore docs, NixOS#4670
        add a pull backup / push restore how-to, NixOS#1552
        add FAQ how to retain original paths, NixOS#4532
        explain difference between --exclude and --pattern, NixOS#4118
        add FAQs for SSH connection issues, NixOS#3866
        improve password FAQ, NixOS#4591
        reiterate that 'file cache names are absolute' in FAQ
    tests:
        cope with ANY error when importing pytest into borg.testsuite, NixOS#4652
        fix broken test that relied on improper zlib assumptions
        test_fuse: filter out selinux xattrs, NixOS#4574
    travis / vagrant:
        misc python versions removed / changed (due to openssl 1.1 compatibility) or added (3.7 and 3.8, for better borg compatibility testing)
        binary building is on python 3.5.9 now
    vagrant:
        add new boxes: ubuntu 18.04 and 20.04, debian 10
        update boxes: openindiana, darwin, netbsd
        remove old boxes: centos 6
        darwin: updated osxfuse to 3.10.4
        use debian/ubuntu pip/virtualenv packages
        rather use python 3.6.2 than 3.6.0, fixes coverage/sqlite3 issue
        use requirements.d/development.lock.txt to avoid compat issues
    travis:
        darwin: backport some install code / order from master
        remove deprecated keyword "sudo" from travis config
        allow osx builds to fail, NixOS#4955 this is due to travis-ci frequently being so slow that the OS X builds just fail because they exceed 50 minutes and get killed by travis.
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Mar 8, 2020
@mweinelt
borgbackup: 1.1.10 → 1.1.11
9e85946 
Version 1.1.11 (2020-03-08)

Compatibility notes:

    When upgrading from borg 1.0.x to 1.1.x, please note:
        read all the compatibility notes for 1.1.0*, starting from 1.1.0b1.
        borg upgrade: you do not need to and you also should not run it.
        borg might ask some security-related questions once after upgrading. You can answer them either manually or via environment variable. One known case is if you use unencrypted repositories, then it will ask about a unknown unencrypted repository one time.
        your first backup with 1.1.x might be significantly slower (it might completely read, chunk, hash a lot files) - this is due to the --files-cache mode change (and happens every time you change mode). You can avoid the one-time slowdown by using the pre-1.1.0rc4-compatible mode (but that is less safe for detecting changed files than the default). See the --files-cache docs for details.
    1.1.11 removes WSL autodetection (Windows 10 Subsystem for Linux). If WSL still has a problem with sync_file_range, you need to set BORG_WORKAROUNDS=basesyncfile in the borg process environment to work around the WSL issue.

Fixes:

    fixed potential index corruption / data loss issue due to bug in hashindex_set, NixOS#4829 Please read and follow the more detailled notes close to the top of this document.
    upgrade bundled xxhash to 0.7.3, NixOS#4891 0.7.2 is the minimum requirement for correct operations on ARMv6 in non-fixup mode, where unaligned memory accesses cause bus errors. 0.7.3 adds some speedups and libxxhash 0.7.3 even has a pkg-config file now.
    upgrade bundled lz4 to 1.9.2
    upgrade bundled zstd to 1.4.4
    fix crash when upgrading erroneous hints file, NixOS#4922
    extract:
        fix KeyError for "partial" extraction, NixOS#4607
        fix "partial" extract for hardlinked contentless file types, NixOS#4725
        fix preloading for old (0.xx) remote servers, NixOS#4652
        fix confusing output of borg extract --list --strip-components, NixOS#4934
    delete: after double-force delete, warn about necessary repair, NixOS#4704
    create: give invalid repo error msg if repo config not found, NixOS#4411
    mount: fix FUSE mount missing st_birthtime, NixOS#4763 NixOS#4767
    check: do not stumble over invalid item key, NixOS#4845
    info: if the archive doesn't exist, print a pretty message, NixOS#4793
    SecurityManager.known(): check all files, NixOS#4614
    Repository.open: use stat() to check for repo dir, NixOS#4695
    Repository.check_can_create_repository: use stat() to check, NixOS#4695
    fix invalid archive error message
    fix optional/non-optional location arg, NixOS#4541
    commit-time free space calc: ignore bad compact map entries, NixOS#4796
    ignore EACCES (errno 13) when hardlinking the old config, NixOS#4730
    --prefix / -P: fix processing, avoid argparse issue, NixOS#4769

New features:

    enable placeholder usage in all extra archive arguments
    new BORG_WORKAROUNDS mechanism, basesyncfile, NixOS#4710
    recreate: support --timestamp option, NixOS#4745
    support platforms without os.link (e.g. Android with Termux), NixOS#4901 if we don't have os.link, we just extract another copy instead of making a hardlink.
    support linux platforms without sync_file_range (e.g. Android 7 with Termux), NixOS#4905

Other:

    ignore --stats when given with --dry-run, but continue, NixOS#4373
    add some ProgressIndicator msgids to code / fix docs, NixOS#4935
    elaborate on "Calculating size" message
    argparser: always use REPOSITORY in metavar, also use more consistent help phrasing.
    check: improve error output for matching index size, see NixOS#4829
    docs:
        changelog: add advisory about hashindex_set bug NixOS#4829
        better describe BORG_SECURITY_DIR, BORG_CACHE_DIR, NixOS#4919
        infos about cache security assumptions, NixOS#4900
        add FAQ describing difference between a local repo vs. repo on a server.
        document how to test exclusion patterns without performing an actual backup
        timestamps in the files cache are now usually ctime, NixOS#4583
        fix bad reference to borg compact (does not exist in 1.1), NixOS#4660
        create: borg 1.1 is not future any more
        extract: document limitation "needs empty destination", NixOS#4598
        how to supply a passphrase, use crypto devices, NixOS#4549
        fix osxfuse github link in installation docs
        add example of exclude-norecurse rule in help patterns
        update macOS Brew link
        add note about software for automating backups, NixOS#4581
        AUTHORS: mention copyright+license for bundled msgpack
        fix various code blocks in the docs, NixOS#4708
        updated docs to cover use of temp directory on remote, NixOS#4545
        add restore docs, NixOS#4670
        add a pull backup / push restore how-to, NixOS#1552
        add FAQ how to retain original paths, NixOS#4532
        explain difference between --exclude and --pattern, NixOS#4118
        add FAQs for SSH connection issues, NixOS#3866
        improve password FAQ, NixOS#4591
        reiterate that 'file cache names are absolute' in FAQ
    tests:
        cope with ANY error when importing pytest into borg.testsuite, NixOS#4652
        fix broken test that relied on improper zlib assumptions
        test_fuse: filter out selinux xattrs, NixOS#4574
    travis / vagrant:
        misc python versions removed / changed (due to openssl 1.1 compatibility) or added (3.7 and 3.8, for better borg compatibility testing)
        binary building is on python 3.5.9 now
    vagrant:
        add new boxes: ubuntu 18.04 and 20.04, debian 10
        update boxes: openindiana, darwin, netbsd
        remove old boxes: centos 6
        darwin: updated osxfuse to 3.10.4
        use debian/ubuntu pip/virtualenv packages
        rather use python 3.6.2 than 3.6.0, fixes coverage/sqlite3 issue
        use requirements.d/development.lock.txt to avoid compat issues
    travis:
        darwin: backport some install code / order from master
        remove deprecated keyword "sudo" from travis config
        allow osx builds to fail, NixOS#4955 this is due to travis-ci frequently being so slow that the OS X builds just fail because they exceed 50 minutes and get killed by travis.

(cherry picked from commit dbff9b5)
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Mar 8, 2020
@mweinelt
borgbackup: 1.1.10 → 1.1.11
055bc68 
Version 1.1.11 (2020-03-08)

Compatibility notes:

    When upgrading from borg 1.0.x to 1.1.x, please note:
        read all the compatibility notes for 1.1.0*, starting from 1.1.0b1.
        borg upgrade: you do not need to and you also should not run it.
        borg might ask some security-related questions once after upgrading. You can answer them either manually or via environment variable. One known case is if you use unencrypted repositories, then it will ask about a unknown unencrypted repository one time.
        your first backup with 1.1.x might be significantly slower (it might completely read, chunk, hash a lot files) - this is due to the --files-cache mode change (and happens every time you change mode). You can avoid the one-time slowdown by using the pre-1.1.0rc4-compatible mode (but that is less safe for detecting changed files than the default). See the --files-cache docs for details.
    1.1.11 removes WSL autodetection (Windows 10 Subsystem for Linux). If WSL still has a problem with sync_file_range, you need to set BORG_WORKAROUNDS=basesyncfile in the borg process environment to work around the WSL issue.

Fixes:

    fixed potential index corruption / data loss issue due to bug in hashindex_set, NixOS#4829 Please read and follow the more detailled notes close to the top of this document.
    upgrade bundled xxhash to 0.7.3, NixOS#4891 0.7.2 is the minimum requirement for correct operations on ARMv6 in non-fixup mode, where unaligned memory accesses cause bus errors. 0.7.3 adds some speedups and libxxhash 0.7.3 even has a pkg-config file now.
    upgrade bundled lz4 to 1.9.2
    upgrade bundled zstd to 1.4.4
    fix crash when upgrading erroneous hints file, NixOS#4922
    extract:
        fix KeyError for "partial" extraction, NixOS#4607
        fix "partial" extract for hardlinked contentless file types, NixOS#4725
        fix preloading for old (0.xx) remote servers, NixOS#4652
        fix confusing output of borg extract --list --strip-components, NixOS#4934
    delete: after double-force delete, warn about necessary repair, NixOS#4704
    create: give invalid repo error msg if repo config not found, NixOS#4411
    mount: fix FUSE mount missing st_birthtime, NixOS#4763 NixOS#4767
    check: do not stumble over invalid item key, NixOS#4845
    info: if the archive doesn't exist, print a pretty message, NixOS#4793
    SecurityManager.known(): check all files, NixOS#4614
    Repository.open: use stat() to check for repo dir, NixOS#4695
    Repository.check_can_create_repository: use stat() to check, NixOS#4695
    fix invalid archive error message
    fix optional/non-optional location arg, NixOS#4541
    commit-time free space calc: ignore bad compact map entries, NixOS#4796
    ignore EACCES (errno 13) when hardlinking the old config, NixOS#4730
    --prefix / -P: fix processing, avoid argparse issue, NixOS#4769

New features:

    enable placeholder usage in all extra archive arguments
    new BORG_WORKAROUNDS mechanism, basesyncfile, NixOS#4710
    recreate: support --timestamp option, NixOS#4745
    support platforms without os.link (e.g. Android with Termux), NixOS#4901 if we don't have os.link, we just extract another copy instead of making a hardlink.
    support linux platforms without sync_file_range (e.g. Android 7 with Termux), NixOS#4905

Other:

    ignore --stats when given with --dry-run, but continue, NixOS#4373
    add some ProgressIndicator msgids to code / fix docs, NixOS#4935
    elaborate on "Calculating size" message
    argparser: always use REPOSITORY in metavar, also use more consistent help phrasing.
    check: improve error output for matching index size, see NixOS#4829
    docs:
        changelog: add advisory about hashindex_set bug NixOS#4829
        better describe BORG_SECURITY_DIR, BORG_CACHE_DIR, NixOS#4919
        infos about cache security assumptions, NixOS#4900
        add FAQ describing difference between a local repo vs. repo on a server.
        document how to test exclusion patterns without performing an actual backup
        timestamps in the files cache are now usually ctime, NixOS#4583
        fix bad reference to borg compact (does not exist in 1.1), NixOS#4660
        create: borg 1.1 is not future any more
        extract: document limitation "needs empty destination", NixOS#4598
        how to supply a passphrase, use crypto devices, NixOS#4549
        fix osxfuse github link in installation docs
        add example of exclude-norecurse rule in help patterns
        update macOS Brew link
        add note about software for automating backups, NixOS#4581
        AUTHORS: mention copyright+license for bundled msgpack
        fix various code blocks in the docs, NixOS#4708
        updated docs to cover use of temp directory on remote, NixOS#4545
        add restore docs, NixOS#4670
        add a pull backup / push restore how-to, NixOS#1552
        add FAQ how to retain original paths, NixOS#4532
        explain difference between --exclude and --pattern, NixOS#4118
        add FAQs for SSH connection issues, NixOS#3866
        improve password FAQ, NixOS#4591
        reiterate that 'file cache names are absolute' in FAQ
    tests:
        cope with ANY error when importing pytest into borg.testsuite, NixOS#4652
        fix broken test that relied on improper zlib assumptions
        test_fuse: filter out selinux xattrs, NixOS#4574
    travis / vagrant:
        misc python versions removed / changed (due to openssl 1.1 compatibility) or added (3.7 and 3.8, for better borg compatibility testing)
        binary building is on python 3.5.9 now
    vagrant:
        add new boxes: ubuntu 18.04 and 20.04, debian 10
        update boxes: openindiana, darwin, netbsd
        remove old boxes: centos 6
        darwin: updated osxfuse to 3.10.4
        use debian/ubuntu pip/virtualenv packages
        rather use python 3.6.2 than 3.6.0, fixes coverage/sqlite3 issue
        use requirements.d/development.lock.txt to avoid compat issues
    travis:
        darwin: backport some install code / order from master
        remove deprecated keyword "sudo" from travis config
        allow osx builds to fail, NixOS#4955 this is due to travis-ci frequently being so slow that the OS X builds just fail because they exceed 50 minutes and get killed by travis.

(cherry picked from commit dbff9b5)
@infinisil infinisil mentioned this pull request Jan 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbp @bjornfor @Fuuzetsu